[ 
https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565030#comment-13565030
 ] 

Gustavo Anatoly commented on HBASE-7462:
----------------------------------------

Hi, Nicolas.

I was searching on test source, and I found this way to mocking server:

{code} MasterServices ms = Mockito.mock(MasterService.class); {code}

I was thinking to use MasterServices, because it has the methods to get 
instance of AssignmentManager and ServerManager, that is everything what the 
tests need. That is correct?

Thanks.
                
> TestDrainingServer is an integration test. It should be a unit test instead
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-7462
>                 URL: https://issues.apache.org/jira/browse/HBASE-7462
>             Project: HBase
>          Issue Type: Wish
>          Components: test
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Priority: Trivial
>              Labels: noob
>
> TestDrainingServer tests the function that allows to say that a regionserver 
> should not get new regions.
> As it is written today, it's an integration test: it starts & stops a cluster.
> The test would be more efficient if it would just check that the 
> AssignmentManager does not use the drained region server; whatever the 
> circumstances (bulk assign or not for example).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to