[ 
https://issues.apache.org/jira/browse/HBASE-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13566277#comment-13566277
 ] 

Lars Hofhansl commented on HBASE-7545:
--------------------------------------

Seen a test failure in 0.94:
{code}
java.lang.AssertionError: Waited too much time for normal batch replication, 
732 instead of 1000
        at org.junit.Assert.fail(Assert.java:93)
        at 
org.apache.hadoop.hbase.replication.TestReplicationSmallTests.loadTesting(TestReplicationSmallTests.java:451)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
        at 
org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:62)
{code}

It seems I should slightly increase the timeout again. Currently it is 1000ms 
with 10 retries. I'm thinking of setting the retries to 15.

                
> [replication] Break out TestReplication into manageable classes
> ---------------------------------------------------------------
>
>                 Key: HBASE-7545
>                 URL: https://issues.apache.org/jira/browse/HBASE-7545
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.96.0, 0.94.5
>
>         Attachments: 7545-0.94.txt, 7545-0.94-v1.txt, HBASE-7545.patch
>
>
> This has been discussed before but after trying to debug the last failure on 
> Jenkins where I saw the time go back and forth (if you don't care about your 
> own sanity do checkout 
> https://builds.apache.org/job/HBase-TRUNK/3726/testReport/junit/org.apache.hadoop.hbase.replication/TestReplicationWithCompression/testDeleteTypes/)
>  I think it is time to break out TestReplication.
> The difficulty is that the setup for the 2 clusters is a lot of code I don't 
> want to duplicate. I'm thinking that we can keep {{setUpBeforeClass}} there 
> and have the other classes extend TestReplication (which should also change 
> name). I'm thinking of the following new classes:
>  - TestReplicationSmallTests, contains the easy methods that don't mess 
> around too much.
>  - TestReplicationQueueFailover, contains one test of the same name
>  - TestReplicationDisableInactivePeer, contains one test of the same name
>  - Rename TestReplicationWithCompression 
> TestReplicationQueueFailoverWithCompression and make it extends 
> TestReplicationQueueFailover.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to