[ 
https://issues.apache.org/jira/browse/HBASE-7495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567508#comment-13567508
 ] 

Liang Xie commented on HBASE-7495:
----------------------------------

Uploaded patch v6,  move the MVCC  setThreadReadPoint from ScannerSeekWorker 
constructor into call block
For passing config object, seems it need to add a new param in StoreScanner's 
constructor, and probably need to repair many broken test cases? In my patch, 
it's initialized just one time in *static* block, i think it's fine as well.
[~yuzhih...@gmail.com], if we move the ExecutorService to HRegionServer class, 
we need to expose it with *static* getter, right? since in StoreScanner class, 
we could not get the current HRegionServer instance easily in current codebase. 
but if we add a static getter method, it'll bring several FindBug warnings.
                
> parallel seek in StoreScanner
> -----------------------------
>
>                 Key: HBASE-7495
>                 URL: https://issues.apache.org/jira/browse/HBASE-7495
>             Project: HBase
>          Issue Type: Bug
>          Components: Scanners
>    Affects Versions: 0.94.3, 0.96.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>         Attachments: HBASE-7495.txt, HBASE-7495.txt, HBASE-7495.txt, 
> HBASE-7495-v2.txt, HBASE-7495-v3.txt, HBASE-7495-v4.txt, HBASE-7495-v4.txt, 
> HBASE-7495-v5.txt, HBASE-7495-v6.txt
>
>
> seems there's a potential improvable space before doing scanner.next:
> {code:title=StoreScanner.java|borderStyle=solid}
>     if (explicitColumnQuery && lazySeekEnabledGlobally) {
>       for (KeyValueScanner scanner : scanners) {
>         scanner.requestSeek(matcher.getStartKey(), false, true);
>       }
>     } else {
>       for (KeyValueScanner scanner : scanners) {
>         scanner.seek(matcher.getStartKey());
>       }
>     }
> {code} 
> we can do scanner.requestSeek or scanner.seek in parallel, instead of current 
> serialization, to reduce latency for special case.
> Any ideas on it ?  I'll have a try if the comments/suggestions are positive:)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to