[ 
https://issues.apache.org/jira/browse/HBASE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569330#comment-13569330
 ] 

Jesse Yates commented on HBASE-7725:
------------------------------------

bq. Parameter name should be attributes, right ?

Yup.

bq. Would the attributes be String or Map ?

String will lead to munging and map will often be too heavy weight. I don't 
want to force it - this is an internal hook, so you know what you are passing - 
you can cast it when you get it. 

bq. Looks like attributes parameter isn't passed on.

Good catch.

bq. I think the requests would be queued. So please modify the @return.

Definitely.

bq. It would be nice to put trunk patch on review board.

Its, unfortunately, going to be more than a little bit different. But yeah, 
I'll post one up soon
                
> Add ability to block on a compaction request for a region
> ---------------------------------------------------------
>
>                 Key: HBASE-7725
>                 URL: https://issues.apache.org/jira/browse/HBASE-7725
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction, Coprocessors, regionserver
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: 0.96.0, 0.94.5
>
>         Attachments: example.java, hbase-7725_0.94-v0.patch, 
> hbase-7725_with-attributes-0.94-v0.patch, 
> hbase-7725_with-attributes-0.94-v1.patch
>
>
> You can request that a compaction be started, but you can't be sure when that 
> compaction request completes. This is a simple update to the 
> CompactionRequest interface and the compact-split thread on the RS that 
> doesn't actually impact the RS exposed interface.
> This is particularly useful for CPs so they can control starting/running a 
> compaction.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to