[ 
https://issues.apache.org/jira/browse/HBASE-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570395#comment-13570395
 ] 

ramkrishna.s.vasudevan commented on HBASE-7698:
-----------------------------------------------

bq.Ram, should we set transitionToFailedOpen to true inside the 
tryTransitionFromOpeningToFailedOpen method?
Any specific reason Jimmy may be am missing what is there in your mind?
The reason for doing it was, the tryTransitionFromOpeningToFailedOpen() does 
not throw any exception out.
So if this method is executed either successfully or failure, we need not retry 
it in the finally.  That was my intention.
bq.Is it possible to make sure Filesystem is not closed before all others are 
closed/shutdown?
Yes this should be the best soln.
As far as the log attached by Sergey(in HBASE-7701) i did not see what caused 
the FS to get closed.  I thought may be being an integration test case there 
were steps to even stop NN abruptly. 
Thanks for the review Jimmy and sorry for the delay.
                
> race between RS shutdown thread and openregionhandler causes region to get 
> stuck
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-7698
>                 URL: https://issues.apache.org/jira/browse/HBASE-7698
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-7698.patch
>
>
> 2013-01-22 17:59:03,237 INFO  [Shutdown of 
> org.apache.hadoop.hbase.fs.HFileSystem@5984cf08] 
> hbase.MiniHBaseCluster$SingleFileSystemShutdownThread(186): Hook closing 
> fs=org.apache.hadoop.hbase.fs.HFileSystem@5984cf08
> ...
> 2013-01-22 17:59:03,411 DEBUG 
> [RS_OPEN_REGION-10.11.2.92,50661,1358906192942-0] regionserver.HRegion(1001): 
> Closing 
> IntegrationTestRebalanceAndKillServersTargeted,66666660,1358906196709.0200b366bc37c5afd1185f7d487c7dfb.:
>  disabling compactions & flushes
> 2013-01-22 17:59:03,411 DEBUG 
> [RS_OPEN_REGION-10.11.2.92,50661,1358906192942-0] regionserver.HRegion(1023): 
> Updates disabled for region 
> IntegrationTestRebalanceAndKillServersTargeted,66666660,1358906196709.0200b366bc37c5afd1185f7d487c7dfb.
> 2013-01-22 17:59:03,415 ERROR 
> [RS_OPEN_REGION-10.11.2.92,50661,1358906192942-0] executor.EventHandler(205): 
> Caught throwable while processing event M_RS_OPEN_REGION
> java.io.IOException: java.io.IOException: java.io.IOException: Filesystem 
> closed
>       at 
> org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1058)
>       at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:974)
>       at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:945)
>       at 
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.cleanupFailedOpen(OpenRegionHandler.java:459)
>       at 
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:143)
>       at 
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:202)
>       at 
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>       at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>       at java.lang.Thread.run(Thread.java:680)
> tryTransitionFromOpeningToFailedOpen or transitionToOpened below is never 
> called and region can get stuck.
> As an added benefit, the meta is already written by that time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to