[
https://issues.apache.org/jira/browse/HBASE-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13572736#comment-13572736
]
Jimmy Xiang commented on HBASE-7698:
------------------------------------
The code doesn't look efficient to me (an existing issue of course). Not a big
deal. I was wondering if we can move calling
tryTransitionFromOpeningToFailedOpen(regionInfo) to the final block, so that we
don't need the local variable transitionToFailedOpen, and we can cover all
scenarios as long as openSuccessful is not true. @Ram, what do you think?
> race between RS shutdown thread and openregionhandler causes region to get
> stuck
> --------------------------------------------------------------------------------
>
> Key: HBASE-7698
> URL: https://issues.apache.org/jira/browse/HBASE-7698
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.4
> Reporter: Sergey Shelukhin
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.96.0, 0.94.5
>
> Attachments: HBASE-7698_0.94.patch, HBASE-7698.patch,
> HBASE-7698_trunk_final.patch, HBASE-7698_withtestcase_1.patch,
> HBASE-7698_withtestcase_1.patch, HBASE-7698_withtestcase.patch
>
>
> 2013-01-22 17:59:03,237 INFO [Shutdown of
> org.apache.hadoop.hbase.fs.HFileSystem@5984cf08]
> hbase.MiniHBaseCluster$SingleFileSystemShutdownThread(186): Hook closing
> fs=org.apache.hadoop.hbase.fs.HFileSystem@5984cf08
> ...
> 2013-01-22 17:59:03,411 DEBUG
> [RS_OPEN_REGION-10.11.2.92,50661,1358906192942-0] regionserver.HRegion(1001):
> Closing
> IntegrationTestRebalanceAndKillServersTargeted,66666660,1358906196709.0200b366bc37c5afd1185f7d487c7dfb.:
> disabling compactions & flushes
> 2013-01-22 17:59:03,411 DEBUG
> [RS_OPEN_REGION-10.11.2.92,50661,1358906192942-0] regionserver.HRegion(1023):
> Updates disabled for region
> IntegrationTestRebalanceAndKillServersTargeted,66666660,1358906196709.0200b366bc37c5afd1185f7d487c7dfb.
> 2013-01-22 17:59:03,415 ERROR
> [RS_OPEN_REGION-10.11.2.92,50661,1358906192942-0] executor.EventHandler(205):
> Caught throwable while processing event M_RS_OPEN_REGION
> java.io.IOException: java.io.IOException: java.io.IOException: Filesystem
> closed
> at
> org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1058)
> at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:974)
> at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:945)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.cleanupFailedOpen(OpenRegionHandler.java:459)
> at
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:143)
> at
> org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:202)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> at java.lang.Thread.run(Thread.java:680)
> tryTransitionFromOpeningToFailedOpen or transitionToOpened below is never
> called and region can get stuck.
> As an added benefit, the meta is already written by that time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
