[
https://issues.apache.org/jira/browse/HBASE-7778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573049#comment-13573049
]
Hadoop QA commented on HBASE-7778:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12568329/hbase-7778.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4361//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4361//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4361//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4361//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4361//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4361//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4361//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4361//console
This message is automatically generated.
> [snapshot 130201 merge] Tests with sleep after minicluster shutdown fail due
> to interrupt flag.
> -----------------------------------------------------------------------------------------------
>
> Key: HBASE-7778
> URL: https://issues.apache.org/jira/browse/HBASE-7778
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-7778.patch
>
>
> Something in the merge has set the interrupted flag on the main test threads
> of TestReplicationDisabledinactivePeer, TestRestartCluster, and
> TestCatalogTrackerOnCluster.
> These unacceptable hacks make the tests run and pass:
> {code}
> diff --git
> a/hbase-server/src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTrackerOnCluster.java
> b/hbase-server/src/test/java/or
> index f3e57d6..a8d2ef7 100644
> ---
> a/hbase-server/src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTrackerOnCluster.java
> +++
> b/hbase-server/src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTrackerOnCluster.java
> @@ -47,6 +47,7 @@ public class TestCatalogTrackerOnCluster {
> // Shutdown hbase.
> UTIL.shutdownMiniHBaseCluster();
> // Give the various ZKWatchers some time to settle their affairs.
> + Thread.interrupted(); // HACK clear interrupt state.
> Thread.sleep(1000);
>
> // Mess with the root location in the running zk. Set it to be nonsense.
> diff --git
> a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRestartCluster.java
> b/hbase-server/src/test/java/org/apache/h
> index 15225e1..9f7f526 100644
> ---
> a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRestartCluster.java
> +++
> b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRestartCluster.java
> @@ -108,6 +108,7 @@ public class TestRestartCluster {
> UTIL.shutdownMiniHBaseCluster();
>
> LOG.info("\n\nSleeping a bit");
> + Thread.interrupted(); // HACK clear interrupt state.
> Thread.sleep(2000);
>
> LOG.info("\n\nStarting cluster the second time");
> diff --git
> a/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationDisableInactivePeer.java
> b/hbase-server/src/t
> index b089fbe..8162f4b 100644
> ---
> a/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationDisableInactivePeer.java
> +++
> b/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationDisableInactivePeer.java
> @@ -50,6 +50,7 @@ public class TestReplicationDisableInactivePeer extends
> TestReplicationBase {
> // enabling and shutdown the peer
> admin.enablePeer("2");
> utility2.shutdownMiniHBaseCluster();
> + Thread.interrupted(); // HACK clear interrupted flag.
>
> byte[] rowkey = Bytes.toBytes("disable inactive peer");
> Put put = new Put(rowkey);
> {code}
> On the snapshot branch and on the trunk branch before the merge, these tests
> passed. Need to figure out how they combination caused this behavior change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
