[
https://issues.apache.org/jira/browse/HBASE-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573823#comment-13573823
]
Andrew Purtell edited comment on HBASE-7233 at 2/7/13 7:28 PM:
---------------------------------------------------------------
Yeah I guess there is a little bit of confusion here. I was thinking Cell can
support getting tag data, and the encoders might not support it (v1) or could
(v2).
Should tags be a concern of Cell or KV?
As maybe an interesting consideration, I only need tags in on disk
representation and actually should not send the ones I'd be working with over
the wire to the client.
bq. I think Andy has found a way to work the tags into the current KeyValue
serialization
I did, but it is ugly IMHO: I store the value length as negative to flag the KV
as one containing tag data, prepend delimited tag data to the user value data,
and parse the tags into in-memory metadata and fix up offsets on KV
instantiation. Do we actually want this? If so, then I guess we can have tagged
KVs mixed with old KVs in a backwards compatible way.
was (Author: apurtell):
Yeah I guess there is a little bit of confusion here. I was thinking Cell
can support getting tag data, and the encoders might not support it (v1) or
could (v2).
Should tags be a concern of Cell or KV?
As maybe an interesting consideration, I only need tags in on disk
representation and actually should not send the ones I'd be working with over
the wire to the client.
bq. I think Andy has found a way to work the tags into the current KeyValue
serialization
I did, but it is ugly IMHO: I store the value length as negative, prepend
delimited tag data to the user value data, and parse the tags into in-memory
metadata and fix up offsets on KV instantiation. Do we actually want this? If
so, then I guess we can have tagged KVs mixed with old KVs in a backwards
compatible way.
> Serializing KeyValues
> ---------------------
>
> Key: HBASE-7233
> URL: https://issues.apache.org/jira/browse/HBASE-7233
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7233sketch.txt, 7233.txt, 7233v10.txt, 7233-v2.txt,
> 7233v3_encoders.txt, 7233v4_encoders.txt, 7233v5_encoders.txt,
> 7233v6_encoder.txt, 7233v7.txt, 7233v9.txt
>
>
> Undo KeyValue being a Writable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
