[
https://issues.apache.org/jira/browse/HBASE-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577033#comment-13577033
]
Ted Yu commented on HBASE-7822:
-------------------------------
{code}
+public class OffPeakCompactions {
{code}
Please add javadoc for the new class. Annotation for audience, too.
{code}
- + CompactSelection.getNumOutStandingOffPeakCompactions());
+ LOG.info("Running an off-peak compaction, selection ratio = " + ratio);
...
+ public long getNumOutStandingOffPeakCompactions() {
{code}
I don't see the new getNumOutStandingOffPeakCompactions() method called.
> clean up compactionrequest and compactselection - part 1
> --------------------------------------------------------
>
> Key: HBASE-7822
> URL: https://issues.apache.org/jira/browse/HBASE-7822
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-7822-v0.patch, HBASE-7822-v0.patch
>
>
> Certain parts of CompactionRequest are unnecessary.
> Off-peak hour management is part way in selection, part way in Store and part
> way in policy.
> Needs to be cleaned up in preparation of having CompactionPolicy return
> CompactionRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
