[
https://issues.apache.org/jira/browse/HBASE-7818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577089#comment-13577089
]
Ted Yu commented on HBASE-7818:
-------------------------------
{code}
+ public void SetOpMetricsReadRequestCount(long value)
{code}
Lower case the starting 'S', same with SetOpMetricsWriteRequestCount().
{code}
+ private void doUpdateNumericPersistentMetrics(Set<byte[]> columnFamilies,
String key, long value) {
+ String cfPrefix = null;
{code}
Indentation should be two spaces.
{code}
* This deletes all old metrics this instance has ever created or updated.
*/
- public void closeMetrics() {
- RegionMetricsStorage.clear();
+ public void closeMetrics(String regionEncodedName) {
{code}
Javadoc no longer matches code.
Can you upload patch for trunk ?
Thanks
> add region level metrics readReqeustCount and writeRequestCount
> ----------------------------------------------------------------
>
> Key: HBASE-7818
> URL: https://issues.apache.org/jira/browse/HBASE-7818
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 0.94.4
> Reporter: Tianying Chang
> Assignee: Tianying Chang
> Priority: Minor
> Fix For: 0.94.6
>
> Attachments: HBASE-7818.patch
>
>
> Request rate at region server level can help identify the hot region server.
> But it will be good if we can further identify the hot regions on that region
> server. That way, we can easily find out unbalanced regions problem.
> Currently, readRequestCount and writeReqeustCount per region is exposed at
> webUI. It will be more useful to expose it through hadoop metrics framework
> and/or JMX, so that people can see the history when the region is hot.
> I am exposing the existing readRequestCount/writeRequestCount into the
> dynamic region level metrics framework. I am not changing/exposing it as rate
> because our openTSDB is taking the raw data of read/write count, and apply
> rate function to display the rate already.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
