[
https://issues.apache.org/jira/browse/HBASE-7290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577366#comment-13577366
]
stack commented on HBASE-7290:
------------------------------
Quick review of patch. All below are total nits not to get in the way of
commit (anything can be done about above findbugs and javadoc warnings -- they
have been showing green of later ... would be pity to go red again).
On the patch, the ErrorHandling.proto looks generally applicable...
Fix tab spacing in protos on commit?
Nice... they show in UI!
Is the change in MasterAdminProtocol right? It removes a critical looking line.
Where is the doc? At least add fat release note on commit (The stuff in
SnapshotDescriptionUtils looks great in the javadoc class comment)
FSVisitor looks generally useful too...
ModifyRegionUtils probably belongs under regionserver package?
And support in shell!
+1 on commit even you would like to address findbugs/javadoc in follow on issue.
> Online snapshots
> -----------------
>
> Key: HBASE-7290
> URL: https://issues.apache.org/jira/browse/HBASE-7290
> Project: HBase
> Issue Type: Bug
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: 7290-mega-v2.txt, 7290-mega-v3.txt, hbase-7290.mega.patch
>
>
> HBASE-6055 will be closed when the offline snapshots pieces get merged with
> trunk. This umbrella issue has all the online snapshot specific patches.
> This will get merged once one of the implementations makes it into trunk.
> Other flavors of online snapshots can then be done as normal patches instead
> of on a development branch. (was: HBASE-6055 will be closed when the online
> snapshots pieces get merged with trunk. This umbrella issue has all the
> online snapshot specific patches. This will get merged once one of the
> implementations makes it into trunk. Other flavors of online snapshots can
> then be done as normal patches instead of on a development branch.)
> (not a fan of the quick edit descirption jira feature)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
