[
https://issues.apache.org/jira/browse/HBASE-7858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579370#comment-13579370
]
Jonathan Hsieh commented on HBASE-7858:
---------------------------------------
[[email protected]], I explicitly asked Ted for this -- though I would have
named it a "pre-merge branch cleanup". Regardless of the name, the goal and
the reason for it is the same.
We need this to be a patch because it in a branch, and the mega patch just
shows what is currently committed.
Ted's reviews is one of the first holistic reviews. It likely catches things
we've missed from being in the trenches for a while. The fixes for the reviews
can't go in "on commit" because it is already committed. We could put them in
"on merge" but merges are complicated enough and we'd probably lose track of
the changes. Thus, IMO they should be fixed with a patch to the HBASE-7290
branch, and so the merge to trunk will be trivial.
> Address review comments merging snapshots branch to trunk
> ---------------------------------------------------------
>
> Key: HBASE-7858
> URL: https://issues.apache.org/jira/browse/HBASE-7858
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
>
> There have been a lot of review comments from
> https://reviews.apache.org/r/9416
> Since our goal of merging snapshot feature to trunk would preserve revision
> history, a separate JIRA is needed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
