[
https://issues.apache.org/jira/browse/HBASE-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579415#comment-13579415
]
Jesse Yates commented on HBASE-7725:
------------------------------------
bq. may not need generic Object attributes to pre/postCompactSelection in if we
pass in the nascent CompactionRequest reference there too
I worry that we will start to pervert the compactionRequest creation logic for
what is a relatively rare case - a user requested compaction via a CP (or at
least that was the original intent, not sure what everyone will do with this).
But an interesting idea (and another refactor :). So instead of passing in the
attributes you pass in a compaction request to the CompactSplitThread?
Something like, "if the request is null we do the usual logic and build the
request only after we get through all the selection logic in HStore. If not
null, we apply the same logic, but set attributes on the compaction request
(e.g. the store files to compact) on the passed in request"? That certainly
gets me what I need (controlled compactions) and hides the attribute business
all the way down.
Is that what you were getting at? I like it Andrew.
> Add generic attributes to CP initiated compaction request AND latch on
> compaction completion
> --------------------------------------------------------------------------------------------
>
> Key: HBASE-7725
> URL: https://issues.apache.org/jira/browse/HBASE-7725
> Project: HBase
> Issue Type: Bug
> Components: Compaction, Coprocessors, regionserver
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Fix For: 0.96.0, 0.94.6
>
> Attachments: example.java, hbase-7725_0.94-v0.patch,
> hbase-7725-v0.patch, hbase-7725-v1.patch, hbase-7725-v3.patch,
> hbase-7725_with-attributes-0.94-v0.patch,
> hbase-7725_with-attributes-0.94-v1.patch
>
>
> You can request that a compaction be started, but you can't be sure when that
> compaction request completes. This is a simple update to the
> CompactionRequest interface and the compact-split thread on the RS that
> doesn't actually impact the RS exposed interface.
> This is particularly useful for CPs so they can control starting/running a
> compaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
