[ 
https://issues.apache.org/jira/browse/HBASE-7861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13579795#comment-13579795
 ] 

nkeywal commented on HBASE-7861:
--------------------------------

I committed v2. TestSecureLoadIncrementalHFiles is unrelated (tested locally).
Yes, I kept the previous interface, but it's not used anymore in HBase. 
I don't mind removing it completely (actually I prefer: it ensures it won't be 
used by HBase at least).
In any case, I would not be comfortable with backporting this in 0.94 (even if 
it's not totally crazy).

Thanks for the review, Stack.
                
> Use the ServerName in the Connection#getClient and Connection#getAdmin code
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-7861
>                 URL: https://issues.apache.org/jira/browse/HBASE-7861
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 7861.v1.patch, 7861.v2.patch
>
>
> This is again a subpart of HBASE-7590. The patch already in HBASE-7590 
> contains a bad fix for this (confusion with seq number). This JIRA tries to 
> fix it correctly.
> The client code mostly uses hostname:port to get the connection to the region 
> server. As a side effect if a server dies and comeback, the client won't 
> notice. This is in theory, because the regions it's looking for are likely to 
> be somewhere else.
> In any case, if we add some dead server management in the client 
> (HBASE-7590), we need to manage do the distinction between the server, to be 
> sure that we're not declaring dead a server that has restarted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to