[ 
https://issues.apache.org/jira/browse/HBASE-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581990#comment-13581990
 ] 

terry zhang commented on HBASE-7886:
------------------------------------

hlog zk node is deleted in  shipEdits() or 
{code:title=ReplicationSource.java|borderStyle=solid}
 if (this.isActive() && (gotIOE || currentNbEntries == 0)) {
        if (this.lastLoggedPosition != this.position) {
          this.manager.logPositionAndCleanOldLogs(this.currentPath,
              this.peerClusterZnode, this.position, queueRecovered, 
currentWALisBeingWrittenTo);
          this.lastLoggedPosition = this.position;
        }
        if (sleepForRetries("Nothing to replicate", sleepMultiplier)) {
          sleepMultiplier++;
        }
        continue;
      }
{code} 
but after patch HBASE-6758. logPositionAndCleanOldLogs can not delete hlog zk 
node when currentWALisBeingWrittenTo is true. When log switched and we can see 
 
    // If we didn't get anything and the queue has an object, it means we
    // hit the end of the file for sure
    return seenEntries == 0 && processEndOfFile(); // seenEntries is 0 when run 
'hlog_roll' in shell

So replicationsource will continue and hlog zk node can not deleted.

{code:title=ReplicationSource.java|borderStyle=solid}

        if(readAllEntriesToReplicateOrNextFile(currentWALisBeingWrittenTo)) {   
     
          continue;
        }
{code} 

                
> [replication] hlog zk node will not delete if client roll hlog
> --------------------------------------------------------------
>
>                 Key: HBASE-7886
>                 URL: https://issues.apache.org/jira/browse/HBASE-7886
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 0.94.4
>            Reporter: terry zhang
>            Assignee: terry zhang
>
> if we use the hbase shell command "hlog_roll" on a regionserver which is 
> configured replication. the Hlog zk node under /hbase/replication/rs/1 can 
> not be deleted.
> this issue is caused by HBASE-6758. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to