[ 
https://issues.apache.org/jira/browse/HBASE-7883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13582206#comment-13582206
 ] 

nkeywal commented on HBASE-7883:
--------------------------------

Nit: there is no need to initialize delta to zero. Personally, I think it 
deserves a test as well, it's a critical part and it should fit into 
TestMemStore. So let say I would be +0.9 here.
@JM: it means less flushes & compactions (if you meet the conditions for this 
patch, obviously). 

                
> Update memstore size when removing the entries in append operation
> ------------------------------------------------------------------
>
>                 Key: HBASE-7883
>                 URL: https://issues.apache.org/jira/browse/HBASE-7883
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.96.0
>            Reporter: Himanshu Vashishtha
>            Assignee: Himanshu Vashishtha
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7883-v1.patch
>
>
> In case of Appends/Increments with VERSION of CF set to 1, the memstore size 
> is not updated when the previous entries are removed from the memstore. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to