[
https://issues.apache.org/jira/browse/HBASE-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584412#comment-13584412
]
Guido Serra aka Zeph commented on HBASE-5694:
---------------------------------------------
[~uws] if this is actually the patch (taken from above)
{code}
--- ThriftServer.java.orig 2012-04-01 23:41:16.881172406 +0200
+++ ThriftServer.java 2012-04-01 23:41:30.177238337 +0200
@@ -477,8 +477,8 @@
get.addColumn(famAndQf[0], famAndQf[1]);
}
}
- get.setTimeRange(Long.MIN_VALUE, timestamp);
}
+ get.setTimeRange(Long.MIN_VALUE, timestamp);
gets.add(get);
}
Result[] result = table.get(gets);
{code}
it is the wrong behavior that I'm getting, as it is inconsistent with the
scannerOpenWithScan
we shall not use the setTimeRange but the setTimestamp... as the signature in
Thrift states:
{code}
471 * Get the specified columns for the specified table and rows at the
specified
472 * timestamp. Returns an empty list if no rows exist.
{code}
and not a range scan from Long.MIN_VALUE to timestamp as implemented above
> getRowsWithColumnsTs() in Thrift service handles timestamps incorrectly
> -----------------------------------------------------------------------
>
> Key: HBASE-5694
> URL: https://issues.apache.org/jira/browse/HBASE-5694
> Project: HBase
> Issue Type: Bug
> Components: Thrift
> Affects Versions: 0.92.1
> Reporter: Wouter Bolsterlee
> Fix For: 0.94.0
>
> Attachments: HBASE-5694.patch, HBASE-5694-trunk-20120402.patch
>
>
> The getRowsWithColumnsTs() method in the Thrift interface only applies the
> timestamp if columns are explicitly specified. However, this method also
> allows for columns to be unspecified (this is even used internally to
> implement e.g. getRows()). The cause of the bug is a minor scoping issue: the
> time range is set inside a wrong if statement.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira