[ 
https://issues.apache.org/jira/browse/HBASE-5694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guido Serra aka Zeph updated HBASE-5694:
----------------------------------------

    Attachment: setTimestamp.patch

up to me the correct patch shall be "setTimestamp.patch" that I computed 
against origin/0.92.0rc4 from the github repository

{code}
index 231a564..4c46a4f 100644
--- a/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
+++ b/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
@@ -413,7 +413,7 @@ public class ThriftServer {
         HTable table = getTable(tableName);
         if (columns == null) {
           Get get = new Get(getBytes(row));
-          get.setTimeRange(Long.MIN_VALUE, timestamp);
+          get.setTimestamp(timestamp);
           Result result = table.get(get);
           return ThriftUtilities.rowResultFromHBase(result);
         }
@@ -426,7 +426,7 @@ public class ThriftServer {
               get.addColumn(famAndQf[0], famAndQf[1]);
           }
         }
-        get.setTimeRange(Long.MIN_VALUE, timestamp);
+        get.setTimestamp(timestamp);
         Result result = table.get(get);
         return ThriftUtilities.rowResultFromHBase(result);
       } catch (IOException e) {
{code}
                
> getRowsWithColumnsTs() in Thrift service handles timestamps incorrectly
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5694
>                 URL: https://issues.apache.org/jira/browse/HBASE-5694
>             Project: HBase
>          Issue Type: Bug
>          Components: Thrift
>    Affects Versions: 0.92.1
>            Reporter: Wouter Bolsterlee
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5694.patch, HBASE-5694-trunk-20120402.patch, 
> setTimestamp.patch
>
>
> The getRowsWithColumnsTs() method in the Thrift interface only applies the 
> timestamp if columns are explicitly specified. However, this method also 
> allows for columns to be unspecified (this is even used internally to 
> implement e.g. getRows()). The cause of the bug is a minor scoping issue: the 
> time range is set inside a wrong if statement.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to