[ 
https://issues.apache.org/jira/browse/HBASE-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584804#comment-13584804
 ] 

Jeffrey Zhong commented on HBASE-7824:
--------------------------------------

@Jean-Marc,

Thanks for reviewing. 

1)
"In HMaster, you are testing if failedServers is null to handle other dead 
servers in SSH. So it can be null there, should it be tested also for META and 
ROOT? (failedServers.contains())"

failedServers can't be null. I can remove the null check to be consistant.
2)
"In ServerManager, does processDeadServer need to be synchronized? Many other 
methods calling deadservers and services are not synchronized."

A good point. it's not needed for the fix at least.
 
                
> Improve master start up time when there is log split work
> ---------------------------------------------------------
>
>                 Key: HBASE-7824
>                 URL: https://issues.apache.org/jira/browse/HBASE-7824
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>             Fix For: 0.94.6
>
>         Attachments: hbase-7824.patch
>
>
> When there is log split work going on, master start up waits till all log 
> split work completes even though the log split has nothing to do with meta 
> region servers.
> It's a bad behavior considering a master node can run when log split is 
> happening while its start up is blocking by log split work. 
> Since master is kind of single point of failure, we should start it ASAP.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to