[ 
https://issues.apache.org/jira/browse/HBASE-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585385#comment-13585385
 ] 

Ted Yu commented on HBASE-7920:
-------------------------------

Tests passed with patch:
{code}
Tests run: 1272, Failures: 0, Errors: 0, Skipped: 13

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 56:07.313s
{code}
bq. Maybe a static isFamilyEssential method on FilterBase.
The type check appears in 4 places. I don't feel there is need to create static 
method.

Will wait for more comment before integration.
                
> Move isFamilyEssential(byte[] name) out of Filter interface in 0.94
> -------------------------------------------------------------------
>
>                 Key: HBASE-7920
>                 URL: https://issues.apache.org/jira/browse/HBASE-7920
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.5
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.94.6
>
>         Attachments: 7920-94.txt
>
>
> As Dave Latham pointed out here:
> https://issues.apache.org/jira/browse/HBASE-5416?focusedCommentId=13584553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13584553
> The addition of isFamilyEssential(byte[] name) in Filter interface in 0.94.5 
> broke backward compatibility.
> Agreement in subsequent discussions on HBASE-5416 was reached: 
> isFamilyEssential(byte[] name) should be lifted from Filter interface into 
> FilterBase class.
> This would allow 0.94.6 to be compatible with 0.94.1 to 0.94.4 releases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to