[ 
https://issues.apache.org/jira/browse/HBASE-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586293#comment-13586293
 ] 

stack commented on HBASE-7255:
------------------------------

I tried doing this:

{code}
Index: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
===================================================================
--- 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
   (revision 1449898)
+++ 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
   (working copy)
@@ -468,6 +468,8 @@
       }
     } finally {
       if (cumulativeMetric > 0 && metric != null) {
+        RegionMetricsStorage.incrNumericMetric(this.metricNamePrefix + metric,
+          cumulativeMetric);
 
       }
     }
{code}

... but there is a whole metrics context missing.   Need to get a lesson from 
Mr. [~eclark]
                
> KV size metric went missing from StoreScanner.
> ----------------------------------------------
>
>                 Key: HBASE-7255
>                 URL: https://issues.apache.org/jira/browse/HBASE-7255
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Elliott Clark
>            Priority: Critical
>             Fix For: 0.96.0
>
>
> In trunk due to the metric refactor, at least the KV size metric went missing.
> See this code in StoreScanner.java:
> {code}
>     } finally {
>       if (cumulativeMetric > 0 && metric != null) {
>       }
>     }
> {code}
> Just an empty if statement, where the metric used to be collected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to