[ 
https://issues.apache.org/jira/browse/HBASE-7953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Marc Spaggiari updated HBASE-7953:
---------------------------------------

    Status: Patch Available  (was: Open)

Here is the idea behind this patch.

The first simple option will have been to simply exit the loop when 
scanner.next() return false. However, doing that will corrupt the performances 
test results accuracy.

If one test never get scanner.next()==false, it will run 30 times 1000000 
scanner.getKey() and scanner.getValue(). However, if another test is facing 
that 20% of its calls, it will run way less scanner.getKey() and 
scanner.getValue(). So at the end, it will be difficult to compare the 2 
results.

The idea here is to track when one test is facing an issue, and restart it to 
make sure it's fully accurate.

Another option will have be to count the number of scanner.getKey() and 
scanner.getValue() effectivly done and compare the performances based on this 
value.

                
> Some HFilePerformanceEvaluation tests might failed because of a 
> scanner.getValue when no more rows.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7953
>                 URL: https://issues.apache.org/jira/browse/HBASE-7953
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>         Attachments: HBASE-7953-v0-trunk.patch
>
>
> There is 2 places in the code (Both trunk and 0.94) where we are trying to 
> get the row value even when scanner.next() returned null. Need to fix that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to