[
https://issues.apache.org/jira/browse/HBASE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588525#comment-13588525
]
Ted Yu commented on HBASE-7114:
-------------------------------
Since name of getFamilyMapOfLongs() is different from the one in 0.94 which
returns the family map, I think we should document this in release notes of
this JIRA and 0.94.6
{code}
+ * @return Map of families to a list of Long increments.
{code}
Please add javadoc for parameters. Description above doesn't seem to match
actual return.
{code}
+import org.junit.experimental.categories.Category;
+@Category(SmallTests.class)
{code}
nit: insert empty line above @Category.
> Increment does not extend Mutation but probably should
> ------------------------------------------------------
>
> Key: HBASE-7114
> URL: https://issues.apache.org/jira/browse/HBASE-7114
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: Andrew Purtell
> Assignee: stack
> Priority: Critical
> Fix For: 0.95.0
>
> Attachments: 7114.txt, 7114v2.txt, 7114v3.txt, 7114v4.txt
>
>
> Increment is the only operation in the class of mutators that does not extend
> Mutation. It mostly duplicates what Mutation provides, but not quite. The
> signatures for setWriteToWAL and getFamilyMap are slightly different. This
> can be inconvenient because it requires special case code and therefore could
> be considered an API design nit. Unfortunately it is not a simple change: The
> interface is marked stable and the internals of the family map are different
> from other mutation types. The latter is why I suspect this was not addressed
> when Mutation was introduced.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
