[ 
https://issues.apache.org/jira/browse/HBASE-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589190#comment-13589190
 ] 

stack commented on HBASE-7692:
------------------------------

I've put comments over in rb.  Highlevel:

+ This is well-thought through quality stuff.  It is great.
+ Do we need all of it?  Can we drop all the Writable stuff in particular 
(HBase is moving away from Writables so we have no use for it).  Do we need all 
the permuations listed here?  Would it even be better to take on a small part 
of this set first?
+ The fixation on 'rowkey' is not apt given it won't always be used for rowkey.
+ Could it be included as a jar rather than as module?  If not, module w/ no 
dependencies would be better (would need to undo the hbase-common current 
dependency)

Thanks Nick.
                
> Add utility class to generate ordered byte[] serialization
> ----------------------------------------------------------
>
>                 Key: HBASE-7692
>                 URL: https://issues.apache.org/jira/browse/HBASE-7692
>             Project: HBase
>          Issue Type: Improvement
>          Components: util
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>             Fix For: 0.95.0
>
>         Attachments: HBASE-7692.v1.patch, HBASE-7692.v2.patch, 
> HBASE-7692.v3.patch, HBASE-7692.v4.patch, HBASE-7692.v5.patch
>
>
> The current Bytes utility class works, but produces output that does not 
> maintain the native sort ordering of the input value. This results in, for 
> example, a negative value that does not necessarily sort before a positive 
> value. HBase should provide a canonical implementation of such a 
> serialization format so that third-parties can reliably build on top of 
> HBase. This will allow an implementation for HIVE-3634, HIVE-2599, or 
> HIVE-2903 that is compatible with similar features in Pig.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to