[ https://issues.apache.org/jira/browse/HBASE-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589204#comment-13589204 ]
Lars Hofhansl commented on HBASE-7944: -------------------------------------- Looks good. +1 for 0.94 The only question I have is: Why haven't we seen issues from currentNbOperations not being reset (beyond the strange log message)? > Replication leaks file reader resource & not reset currentNbOperations > ---------------------------------------------------------------------- > > Key: HBASE-7944 > URL: https://issues.apache.org/jira/browse/HBASE-7944 > Project: HBase > Issue Type: Sub-task > Reporter: Jeffrey Zhong > Assignee: Jeffrey Zhong > Fix For: 0.95.0, 0.98.0 > > Attachments: 0.94.patch, hbase-7944.patch > > > When I trace test case TestReplicationQueueFailover, I found current > replication logic has two following issues: > 1) leak file reader when finishing read a file in function finishCurrentFile > 2) never reset currentNbOperations(this can be seen in the attached error > log) such as "currentNbOperations:12655 and seenEntries:0 and size: 0" > inconsistant info. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira