[
https://issues.apache.org/jira/browse/HBASE-7964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590147#comment-13590147
]
Hadoop QA commented on HBASE-7964:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12571503/HBASE-7964-v0.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4613//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4613//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4613//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4613//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4613//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4613//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4613//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4613//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4613//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4613//console
This message is automatically generated.
> requestCompaction priority argument is not used (except for user compaction
> check)
> ----------------------------------------------------------------------------------
>
> Key: HBASE-7964
> URL: https://issues.apache.org/jira/browse/HBASE-7964
> Project: HBase
> Issue Type: Bug
> Components: Compaction
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-7964-v0.patch
>
>
> In some places, like major compaction chore or requesting interface for
> coproc, we pass priority value to requestCompaction.
> Checking the code in trunk and old code in 94, I see that neither uses this
> value properly; first, they check it for being user-level. Then they do this:
> {code}
> // everything went better than expected. create a compaction request
> int pri = getCompactPriority(priority);
> ret = new CompactionRequest(region, this, filesToCompact, isMajor,
> pri);
> {code}
> getPriority does:
> {code}
> // If this is a user-requested compaction, leave this at the highest
> priority
> if(priority == PRIORITY_USER) {
> return PRIORITY_USER;
> } else {
> return this.blockingStoreFileCount - this.storefiles.size();
> }
> {code}, so non-user caller value is just thrown away. Probably if it's not
> NO_PRIORITY, it needs to be used. Overall priority code needs cleanup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
