[ 
https://issues.apache.org/jira/browse/HBASE-7995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592664#comment-13592664
 ] 

stack commented on HBASE-7995:
------------------------------

+1

Thanks for doing this Nick.

I think ITM came in w/ the first MR hookups done by a kind gentleman over at 
IBM.

I might have done Export.  Should have been smarter and used ITM.

I can go back through svn/git history to jog by my old brain if you need more 
than the above.
                
> Export$Exporter could be replaced with IdentityTableMapper
> ----------------------------------------------------------
>
>                 Key: HBASE-7995
>                 URL: https://issues.apache.org/jira/browse/HBASE-7995
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>            Reporter: Nick Dimiduk
>            Priority: Minor
>
> The Mapper implementation in Export looks identical to IdentityTableMapper, 
> except for the (poor) exception handling. I'd like to consolidate on 
> IdentityTableMapper, but I'm looking for some historical perspective before 
> doing so (cc [~stack])
> Export$Exporter's map method:
> {code}
>     public void map(ImmutableBytesWritable row, Result value, Context context)
>     throws IOException {
>       try {
>         context.write(row, value);
>       } catch (InterruptedException e) {
>         e.printStackTrace();
>       }
>     }
> {code}
> IdentityTableMapper's map method:
> {code}
>   public void map(ImmutableBytesWritable key, Result value, Context context)
>   throws IOException, InterruptedException {
>     context.write(key, value);
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to