[ 
https://issues.apache.org/jira/browse/HBASE-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593262#comment-13593262
 ] 

Hadoop QA commented on HBASE-7482:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12571922/HBASE-7482-trunk.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestMasterFailover
                  
org.apache.hadoop.hbase.replication.TestReplicationQueueFailover
                  
org.apache.hadoop.hbase.catalog.TestMetaMigrationConvertingToPB
                  
org.apache.hadoop.hbase.replication.TestReplicationQueueFailoverCompressed

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4663//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4663//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4663//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4663//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4663//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4663//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4663//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4663//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4663//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/4663//console

This message is automatically generated.
                
> Port HBASE-7442 HBase remote CopyTable not working when security enabled to 
> trunk
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-7482
>                 URL: https://issues.apache.org/jira/browse/HBASE-7482
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: James Kinley
>            Priority: Critical
>             Fix For: 0.95.0
>
>         Attachments: HBASE-7482-trunk.patch
>
>
> Excerpt about the choice of solution from :
> The first option was actually quite messy to implement. {{clusterId}} and 
> {{conf}} are fixed in *{{HBaseClient}}* when it's created and cached by 
> *{{SecureRpcEngine}}*, so to implement the fix here I would have had to pass 
> the different cluster {{confs}} up through *{{HConnectionManager}}* and 
> *{{HBaseRPC}}* in order to override the clusterId in 
> *{{SecureClient#SecureConnection}}*.
> I've gone with the second option of creating and caching different 
> *{{SecureClients}}* for the local and remote clusters in 
> *{{SecureRpcEngine}}* - keyed off of the {{clusterId}} instead of the default 
> *{{SocketFactory}}*. I think this is a cleaner solution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to