[
https://issues.apache.org/jira/browse/HBASE-8003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593354#comment-13593354
]
Hadoop QA commented on HBASE-8003:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12572069/8003.v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestMasterFailover
org.apache.hadoop.hbase.replication.TestReplicationQueueFailover
org.apache.hadoop.hbase.catalog.TestMetaMigrationConvertingToPB
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4665//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4665//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4665//console
This message is automatically generated.
> Threads#getBoundedCachedThreadPool harcodes the time unit to seconds
> --------------------------------------------------------------------
>
> Key: HBASE-8003
> URL: https://issues.apache.org/jira/browse/HBASE-8003
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Trivial
> Fix For: 0.98.0
>
> Attachments: 8003.v1.patch, 8003.v1.patch
>
>
> /**
> * Create a new CachedThreadPool with a bounded number as the maximum
> * thread size in the pool.
> *
> * @param maxCachedThread the maximum thread could be created in the pool
> * @param timeout the maximum time to wait
> * @param unit the time unit of the timeout argument
> * @param threadFactory the factory to use when creating new threads
> * @return threadPoolExecutor the cachedThreadPool with a bounded number
> * as the maximum thread size in the pool.
> */
> public static ThreadPoolExecutor getBoundedCachedThreadPool(
> int maxCachedThread, long timeout, TimeUnit unit,
> ThreadFactory threadFactory) {
> ThreadPoolExecutor boundedCachedThreadPool =
> new ThreadPoolExecutor(maxCachedThread, maxCachedThread, timeout,
> TimeUnit.SECONDS, new LinkedBlockingQueue<Runnable>(), threadFactory);
> // allow the core pool threads timeout and terminate
> boundedCachedThreadPool.allowCoreThreadTimeOut(true);
> return boundedCachedThreadPool;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
