[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595366#comment-13595366
]
Hadoop QA commented on HBASE-7791:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12572434/HBASE-7791-v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplicationQueueFailover
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//console
This message is automatically generated.
> Compaction USER_PRIORITY is slightly broken
> -------------------------------------------
>
> Key: HBASE-7791
> URL: https://issues.apache.org/jira/browse/HBASE-7791
> Project: HBase
> Issue Type: Bug
> Components: Compaction
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Minor
> Attachments: HBASE-7791-v0.patch, HBASE-7791-v1.patch
>
>
> The code to get compaction priority is as such:
> {code} public int getCompactPriority(int priority) {
> // If this is a user-requested compaction, leave this at the highest
> priority
> if(priority == Store.PRIORITY_USER) {
> return Store.PRIORITY_USER;
> } else {
> return this.blockingStoreFileCount - this.storefiles.size();
> }
> }
> {code}.
> PRIORITY_USER is 1.
> The priorities are compared as numbers in HRegion, so compactions of blocking
> stores will override user priority (probably intended); also, if you have
> blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
> cause at least this:
> LOG.debug("Warning, compacting more than " +
> comConf.getMaxFilesToCompact() +
> " files because of a user-requested major compaction");
> as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
