[ 
https://issues.apache.org/jira/browse/HBASE-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595918#comment-13595918
 ] 

Dave Latham commented on HBASE-7153:
------------------------------------

Thanks guys for taking a look.

Fixing the array syntax alone is not enough.  When you invoke "hbase zkcli" it 
turns around and first invokes "hbase 
org.apache.hadoop.hbase.zookeeper.ZooKeeperMainServerArg" which will then pick 
up the server options, cause GC output to appear in standard out, which then 
gets picked up on the command line for zkcli causing it to fail.

Also, there are many other tools you can invoke that are more likely to 
"client" than "server" options.  For example, "bin/hbase org.jruby.Main 
region_mover.rb" or "bin/hbase org.apache.hadoop.hbase.mapreduce.CopyTable" or 
"bin/hbase version" or "bin/hbase org.apache.hadoop.hbase.mapreduce.Export".  
The whitelist of server commands is shorter and easier to maintain than a 
whitelist of client commands.
                
> print gc option in hbase-env.sh affects hbase zkcli
> ---------------------------------------------------
>
>                 Key: HBASE-7153
>                 URL: https://issues.apache.org/jira/browse/HBASE-7153
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.94.0
>            Reporter: wonderyl
>            Assignee: Dave Latham
>             Fix For: 0.95.0, 0.98.0, 0.94.6
>
>         Attachments: 7153-0.94.txt, HBASE-7153-0.94.patch
>
>
> I un-commented the -verbose:gc option in hbase-env.sh, which print out the gc 
> info.
> but when I use hbase zkcli to check zk, it can not connect to the server.
> the problem is zkcli uses "hbase 
> org.apache.hadoop.hbase.zookeeper.ZooKeeperMainServerArg" to get the 
> server_arg in the script hbase. when gc verbose option is open, the output of 
> ZooKeeperMainServerArg is with gc info, which masses up with server_arg. and 
> this is the reason stop zkcli working.
> I think the easiest way to fix this is to trim the gc info out of server_arg 
> in the hbase script.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to