[ 
https://issues.apache.org/jira/browse/HBASE-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596915#comment-13596915
 ] 

Raymond Liu commented on HBASE-8012:
------------------------------------

oops.   It just make reseekto 's behavior more correct and simulate the 
behavior of seekto ->  It just make reseek 's behavior more correct and 
simulate the behavior of seek
                
> Reseek should position to the beginning of file for the first time it is 
> invoked with a KV smaller than the first KV in file
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8012
>                 URL: https://issues.apache.org/jira/browse/HBASE-8012
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.94.5
>            Reporter: Raymond Liu
>            Assignee: Raymond Liu
>            Priority: Minor
>             Fix For: 0.98.0
>
>         Attachments: HBASE-8012.patch, HBASE-8012.patch, HBASE-8012_v2.patch
>
>
> The storeFileScanner's seekAtOrAfter method will position at the beginning of 
> the file when the passed KV is smaller than first KV in file. While for 
> reseekAtOrAfter, I think it should also do the same thing when it is the 
> first time it been seeked. originally, this is workaround by adding a 
> isReseekable property in StoreFileScanner, and is checked upon each 
> enforceSeek(), if it is not seeked before, it will go with seek approaching 
> instead of reseek approaching. While why not make reseekAtOrAfter working 
> correctly for the first time it been reseek (also never been seek before), 
> since the file is never seeked before, so position it at the beginning of the 
> file don't break the idea of "reseek", say never rewind.
> It will save the effort for HBASE-8001, with this fixed, it won't need to 
> check isReseekable any more.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to