[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600138#comment-13600138
]
Ted Yu commented on HBASE-7845:
-------------------------------
For HFileReaderV2.seekTo():
{code}
* @return -1 if the key is earlier than the first key of the file,
- * 0 if we are at the given key, and 1 if we are past the given key
+ * 0 if we are at the given key, 1 if we are past the given key
+ * -2 if the key is earlier than the first key of the file while
{code}
Is -1 no longer returned ?
In TestKeyValue.java, some variables are renamed:
{code}
- KeyValue rowA = new
KeyValue(Bytes.toBytes("testtable,www.hbase.org/,1234"),
+ KeyValue row1 = new
KeyValue(Bytes.toBytes("testtable,www.hbase.org/,1234"),
{code}
Would be nice if the renaming is not done so that reviewers get to the gist of
your change.
{code}
+ * @return newKey: the new generated faked key
+ */
+ public byte[] getFakedKey(final byte[] leftKey, final byte[] rightKey) {
{code}
'new generated' -> 'newly generated'
Please add javadoc for the two parameters.
{code}
+ //return KeyValue.createFirstOnRow(newRowKey, family, null).getKey();
{code}
Remove the above comment.
[~lhofhansl], [~liyin], [~stack]:
Mind taking a look ?
> optimize hfile index key
> ------------------------
>
> Key: HBASE-7845
> URL: https://issues.apache.org/jira/browse/HBASE-7845
> Project: HBase
> Issue Type: Improvement
> Components: HFile
> Affects Versions: 0.96.0
> Reporter: Liang Xie
> Assignee: Liang Xie
> Fix For: 0.98.0
>
> Attachments: HBASE-7845.txt, HBASE-7845-v2.txt, HBASE-7845-v3.txt,
> HBASE-7845-v4.txt, HBASE-7845-v5.txt, HBASE-7845-v6.txt
>
>
> Leveldb uses ByteWiseComparatorImpl::FindShortestSeparator() &
> FindShortSuccessor() to reduce index key size, it would be helpful under
> special conditions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
