[ https://issues.apache.org/jira/browse/HBASE-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601978#comment-13601978 ]
Jeffrey Zhong commented on HBASE-8097: -------------------------------------- [~ted_yu] You raised a good point. Since we just reput the dead server in queue, should we updated the timestamp at all. The timestamp updated in DeadServer.add seems bogus to me. > MetaServerShutdownHandler may potentially keep bumping up > DeadServer.numProcessing > ---------------------------------------------------------------------------------- > > Key: HBASE-8097 > URL: https://issues.apache.org/jira/browse/HBASE-8097 > Project: HBase > Issue Type: Bug > Reporter: Jeffrey Zhong > Assignee: Jeffrey Zhong > Fix For: 0.96.0 > > Attachments: 8097.txt, hbase-8097_1.patch > > > {code} > } catch (IOException ioe) { > this.services.getExecutorService().submit(this); > this.deadServers.add(serverName); > throw new IOException("failed log splitting for " + > serverName + ", will retry", ioe); > } > {code} > this.deadServers.add(serverName); will keep incrementing > DeadServer.numProcessing > We can't get rid of numProcessing by just checking deadServers.size() because > deadServers is also used to report some historically failed RSs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira