[ 
https://issues.apache.org/jira/browse/HBASE-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602010#comment-13602010
 ] 

Hudson commented on HBASE-8094:
-------------------------------

Integrated in hbase-0.95 #72 (See 
[https://builds.apache.org/job/hbase-0.95/72/])
    HBASE-8094 TestTableInputFormatScan doesn't assert anything (Nick Dimiduk) 
(Revision 1456286)

     Result = FAILURE
enis : 
Files : 
* 
/hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan.java

                
> TestTableInputFormatScan doesn't assert anything
> ------------------------------------------------
>
>                 Key: HBASE-8094
>                 URL: https://issues.apache.org/jira/browse/HBASE-8094
>             Project: HBase
>          Issue Type: Sub-task
>          Components: mapreduce, test
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>             Fix For: 0.95.0, 0.98.0
>
>         Attachments: 0001-HBASE-8094-fix-broken-TestTableInputFormatScan.patch
>
>
> This test makes assertions from within the Reducer. These tests are not 
> respected because the control harness asserts only that jobs complete, not 
> that they succeed.
> Verify this is true by adding a failure to the reducer:
> {noformat}
> $ git diff 
> diff --git 
> a/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan.java
>  
> b/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan.java
> index bab9633..322cb4f 100644
> --- 
> a/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan.java
> +++ 
> b/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan.java
> @@ -160,6 +160,7 @@ public class TestTableInputFormatScan {
>        if (lastRow != null && lastRow.length() > 0) {
>          assertEquals(lastRow, last);
>        }
> +      assertTrue(false);
>      }
>  
>    }
> {noformat}
> The test still passes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to