[ 
https://issues.apache.org/jira/browse/HBASE-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Dimiduk updated HBASE-7938:
--------------------------------

    Attachment: 0001-HBASE-7938-Add-integration-test-for-ImportTsv-LoadIn.patch

How do you guys let me get away with this slop?

New patch, cleans up:
 - deleted redundant code from TestImportTsv, using existing code in the test 
utilities.
 - added a couple helpers to HBaseCommonTestingUtility.
 - set dataTestDirOnTestFS to deleteOnExit when TestFS is local. This matched 
behavior of when TestFS is not local.
 - IntegrationTestImportTsv no longer extends TestImportTsv, primarily because 
the IT suffered a kind of split-brain syndrom when resolving the Configuration. 
Instead of inheritance, just helpers in test utils and protected static methods 
from ImportTsv.

The test works as intended when run stand-alone, but FAILS when run via maven. 
It looks like HFileOutputFormat is creating the paritions file on localFs 
instead of HDFS. I don't yet know why, but my most recent patch on HBASE-4285 
gets rid of that nonsense, at least in part. I'll try rebasing that patch onto 
this one and see how the test behaves.
                
> Add integration test for ImportTsv/LoadIncrementalHFiles workflow
> -----------------------------------------------------------------
>
>                 Key: HBASE-7938
>                 URL: https://issues.apache.org/jira/browse/HBASE-7938
>             Project: HBase
>          Issue Type: Sub-task
>          Components: mapreduce
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>             Fix For: 0.95.0, 0.98.0
>
>         Attachments: 
> 0001-HBASE-7938-Add-integration-test-for-ImportTsv-LoadIn.patch, 
> 0001-HBASE-7938-Add-integration-test-for-ImportTsv-LoadIn.patch, 
> 0001-HBASE-7938-Add-integration-test-for-ImportTsv-LoadIn.patch
>
>
> We have existing unit tests for smoke-testing the packaged MR jobs, however 
> they do not create a runtime environment that is true to running on a real MR 
> cluster. This is particularly true in regard to classpaths (HBASE-7934) but 
> also other static state (HBASE-4802). An integration test that can be pointed 
> to run on a pseudo-distributed Hadoop deployed on localhost would find these 
> kinds of problems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to