[ 
https://issues.apache.org/jira/browse/HBASE-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602754#comment-13602754
 ] 

Enis Soztutar commented on HBASE-7938:
--------------------------------------

bq. This business is fixed in HBASE-4285. I do away with the symlink stuff and 
drop the partitions file in /tmp instead of the working directory. I also 
request that the file be deleted at FS close.
Ok, we can get HBASE-4285 committed after this. 
bq. The point of the integration test (in my mind) is that it can be run on a 
real cluster. If that's desirable for the tests in TestImportTsv, they might as 
well be merged
I haven't inspected the tests in TestImportTsv. It is your call, if you think 
that we don't need them in IT, it is fine. 
bq. Personally, I don't think we gain very much by having the integration test 
stuff tied into maven.
There is some value to running these tests in mini cluster more as well. But 
the bigger value is to run them against an actual cluster. Whether we run it 
via maven or IntegrationTestsDriver is a matter of convenience I think. 
bq. I think we're better off writing them all as Tools with a main that can be 
run against an externally specified conf
I think it is also necessary for these tests to be discoverable and run 
automatically from maven / IntegrationTestsDriver. We could not expect all of 
the users to know every test. But if we could be in a state where we can rely 
on these tests 100%, then we can say to the users that, once you setup your 
cluster, run these tests to see whether there is anything wrong with the setup. 
                
> Add integration test for ImportTsv/LoadIncrementalHFiles workflow
> -----------------------------------------------------------------
>
>                 Key: HBASE-7938
>                 URL: https://issues.apache.org/jira/browse/HBASE-7938
>             Project: HBase
>          Issue Type: Sub-task
>          Components: mapreduce
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>             Fix For: 0.95.0, 0.98.0
>
>         Attachments: 
> 0001-HBASE-7938-Add-integration-test-for-ImportTsv-LoadIn.patch, 
> 0001-HBASE-7938-Add-integration-test-for-ImportTsv-LoadIn.patch, 
> 0001-HBASE-7938-Add-integration-test-for-ImportTsv-LoadIn.patch
>
>
> We have existing unit tests for smoke-testing the packaged MR jobs, however 
> they do not create a runtime environment that is true to running on a real MR 
> cluster. This is particularly true in regard to classpaths (HBASE-7934) but 
> also other static state (HBASE-4802). An integration test that can be pointed 
> to run on a pseudo-distributed Hadoop deployed on localhost would find these 
> kinds of problems.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to