[ 
https://issues.apache.org/jira/browse/HBASE-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603798#comment-13603798
 ] 

Jean-Marc Spaggiari commented on HBASE-7930:
--------------------------------------------

First thing, thanks for looking at it!

bq. For the test, can we use the utility assertErrors() and assertNoErrors() in 
TestHBaseFsck? By this way, we will be sure the list of expected errors.
Unfortunatly we can't. asserErrors() verifies that ALL the errors you are 
giving it are there, and only those errors. However here, there is some other 
errors triggered because of the entries removed. I used asserTrue to focus on 
the specific ERROR_CODE.EMPTY_META_CELL and not be "polluted" by the other 
errors. I can still build the full list of errors triggered if required, and 
user assertErrors, but that will also validate some other errors which are not 
related to this specific test case.

bq. Should we also put this fix in OfflineMetaRepair?

I don't think we need. OfflineMetaRepair will call rebuildMeta which will call 
sidelineOldMeta and createNewMeta. That will backup the meta and create a 
proper one, which will not have any empty REGIONINFO_QUALIFIER.
                
> hbck should provide an option to fix .META. rows with empty 
> REGIONINFO_QUALIFIER
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-7930
>                 URL: https://issues.apache.org/jira/browse/HBASE-7930
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>             Fix For: 0.95.0
>
>         Attachments: HBASE-7930-v0-trunk.patch, HBASE-7930-v1-trunk.patch, 
> HBASE-7930-v2-trunk.patch
>
>
> Today when master and HBCK are reporting empty REGIONINFO_QUALIFIER .META. 
> rows, we need to manually delete them from the .META. region. We need to 
> enhance hbck to do that automatically.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to