[ 
https://issues.apache.org/jira/browse/HBASE-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604472#comment-13604472
 ] 

stack commented on HBASE-7679:
------------------------------

ConcatenatedLists should have unit test.

Should this define be in the Interface or do you think it implementation 
specific?

+  public static final String BLOCKING_STOREFILES_KEY = 
"hbase.hstore.blockingStoreFiles";

This has to be public?

+  public byte[] getMetadataValue(byte[] key) {

On StripeStoreFileManager, do we know if this approach has merit?  Have we run 
models or actual test runs and can see it saves i/o?  Would be interesting to 
know.  Do we have to commit it to figure this out?  I can see committing all 
the refactorings which allow different compaction policies but would think a 
compaction engine would need to have proven merit before it goes in?  What you 
think Sergey?

Do we have to have a L0?  Can we not flush multiple files when we flush, one 
per boundary in the region?  Was that thought just too much work flushing?
                
> implement store file management for stripe compactions
> ------------------------------------------------------
>
>                 Key: HBASE-7679
>                 URL: https://issues.apache.org/jira/browse/HBASE-7679
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-7667-and-7603-v0-incomplete.patch, 
> HBASE-7667-and-7603-v0-incomplete.patch, HBASE-7667-and-7603-v1.patch, 
> HBASE-7667-and-7603-v1.patch, HBASE-7667-v1.patch, HBASE-7667-v1.patch, 
> HBASE-7667-v2.patch, HBASE-7667-v2.patch, HBASE-7667-v3.patch, 
> HBASE-7679-v4.patch, HBASE-7679-v5.patch, HBASE-7679-v6.patch, 
> HBASE-7679-v7-.patch, HBASE-7679-v7.patch, HBASE-7679-v8.patch, 
> HBASE-7679-v9.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to