[ 
https://issues.apache.org/jira/browse/HBASE-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608328#comment-13608328
 ] 

Nick Dimiduk commented on HBASE-8158:
-------------------------------------

The logic here is dumb! We should give priority to the common case, not the 
broken MRv2 test scenario.

According to the existing comment around JarFinder, it was only needed on 
hadoop-0.23 for test cases. Indeed, JarFinder came out of hadoop-0.23 test 
code. Based on the that comment alone, it's not clear to me if MRv2 will ship 
the jar in the common case. I suggest the logic be:

# try use existing {{findContainingJar}}. This will provide for normal MRv1 
jobs (and maybe normal MRv2 jobs).
# try use Backported {{JarFinder}}. This will provide for MRv1 "HCat Scenario" 
jobs, MRv2 test jobs (and maybe normal MRv2 jobs).
# throw exception. It should fail configuring the job if the desired dependency 
cannot be found.
                
> Backport HBASE-8140 "TableMapReduceUtils#addDependencyJar fails when nested 
> inside another MR job"
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8158
>                 URL: https://issues.apache.org/jira/browse/HBASE-8158
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 0.94.7
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: 8158-port-jarfinder-0.94.patch, 
> 8158-port-jarfinder-0.94.patch
>
>
> Assess the stability of the JarFinder util class from Hadoop-2, as a 
> candidate for backporting to 0.94.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to