[
https://issues.apache.org/jira/browse/HBASE-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608501#comment-13608501
]
Jonathan Hsieh commented on HBASE-7848:
---------------------------------------
Do we need to explicitly call the release table lock release in the catch case
here? an exn in the prepare could be a failed taken (which won't need release)
or some io exception (where we don't know if we need to release it or not?).
{code}
throws HBaseSnapshotException {
TakeSnapshotHandler handler;
try {
- handler = new EnabledTableSnapshotHandler(snapshot, master, this);
+ handler = new EnabledTableSnapshotHandler(snapshot, master,
this).prepare();
this.executorService.submit(handler);
this.handler = handler;
- } catch (IOException e) {
+ } catch (Exception e) {
// cleanup the working directory by trying to delete it from the fs.
Path workingDir =
SnapshotDescriptionUtils.getWorkingSnapshotDir(snapshot, rootDir);
try {
{code}
> Use ZK-based read/write lock to make flush-type snapshot robust against table
> enable/disable/alter
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-7848
> URL: https://issues.apache.org/jira/browse/HBASE-7848
> Project: HBase
> Issue Type: Improvement
> Components: snapshots
> Affects Versions: 0.96.0
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 7848-v1.txt, 7848-v2.txt, hbase-7848_v2.patch
>
>
> Current region split following flush would fail snapshot.
> We can utilize ZK-based read/write lock to make flush-type snapshot robust
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
