[
https://issues.apache.org/jira/browse/HBASE-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609193#comment-13609193
]
Ted Yu commented on HBASE-7878:
-------------------------------
Do we need to use Set for processedLogs and corruptedLogs ?
Each log would be either in processed or corrupted state. I think there
wouldn't be duplicate entry in the List representation.
bq. that the juliet HLog creation should have failed the split right?
As I said above, that didn't happen due to check for orphan hlog missing the
juliet HLog.
bq. I see that though the patch was simple now this JIRA is more of testcase
correction.
I think my patch exposed different behavior in tests (w.r.t.
ZombieNewLogWriterRegionServer) due to timing.
I am quite certain that patch v14 would make tests consistently pass.
> recoverFileLease does not check return value of recoverLease
> ------------------------------------------------------------
>
> Key: HBASE-7878
> URL: https://issues.apache.org/jira/browse/HBASE-7878
> Project: HBase
> Issue Type: Bug
> Components: util
> Affects Versions: 0.95.0, 0.94.6
> Reporter: Eric Newton
> Assignee: Ted Yu
> Priority: Critical
> Fix For: 0.95.0, 0.98.0, 0.94.7
>
> Attachments: 7878.94, 7878-94.addendum, 7878-94.addendum2,
> 7878-trunk.addendum, 7878-trunk.addendum2, 7878-trunk-v10.txt,
> 7878-trunk-v11-test.txt, 7878-trunk-v12.txt, 7878-trunk-v13.txt,
> 7878-trunk-v14.txt, 7878-trunk-v15.patch, 7878-trunk-v2.txt,
> 7878-trunk-v3.txt, 7878-trunk-v4.txt, 7878-trunk-v5.txt, 7878-trunk-v6.txt,
> 7878-trunk-v7.txt, 7878-trunk-v8.txt, 7878-trunk-v9.txt, 7878-trunk-v9.txt
>
>
> I think this is a problem, so I'm opening a ticket so an HBase person takes a
> look.
> Apache Accumulo has moved its write-ahead log to HDFS. I modeled the lease
> recovery for Accumulo after HBase's lease recovery. During testing, we
> experienced data loss. I found it is necessary to wait until recoverLease
> returns true to know that the file has been truly closed. In FSHDFSUtils,
> the return result of recoverLease is not checked. In the unit tests created
> to check lease recovery in HBASE-2645, the return result of recoverLease is
> always checked.
> I think FSHDFSUtils should be modified to check the return result, and wait
> until it returns true.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
