[
https://issues.apache.org/jira/browse/HBASE-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609482#comment-13609482
]
Ted Yu commented on HBASE-8028:
-------------------------------
{code}
+ boolean isSyncToWalSucessfull = false;
{code}
Typo: Sucess.
{code}
+ if(!isSyncToWalSucessfull){
{code}
nit: space between if and (, ) and {.
{code}
+ public void rollbackUpsert(List<? extends Cell> newKVsToRollback,
+ List<? extends Cell> oldKVsToReplay, final long mvccStartPoint) {
{code}
Should rollbackUpsert() return boolean to indicate whether the rollback has
succeeded ?
{code}
+ * Rollbacks a upsert transaction in the memstore (used in case of
append/increment).
{code}
'Rollbacks a upsert' -> 'Rolls back an upsert'
{code}
+ * Iterates over the given set and delete the kvs which matches with the
passed kv and
+ * mvccReadpoint. Set changeSize to true if the memstore size is also needs
to change.
{code}
should read:
{code}
+ * Iterates over the given set and deletes the kvs which match the passed kv
and
+ * mvccReadpoint. Sets changeSize to true if the memstore size also needs to
change.
{code}
> Append, Increment: Adding rollback support
> ------------------------------------------
>
> Key: HBASE-8028
> URL: https://issues.apache.org/jira/browse/HBASE-8028
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.94.5
> Reporter: Himanshu Vashishtha
> Assignee: Himanshu Vashishtha
> Fix For: 0.95.0
>
> Attachments: HBase-8028-v1.patch, HBase-8028-v2.patch,
> HBase-8028-with-Increments-v1.patch
>
>
> In case there is an exception while doing the log-sync, the memstore is not
> rollbacked, while the mvcc is _always_ forwarded to the writeentry created at
> the beginning of the operation. This may lead to scanners seeing results
> which are not synched to the fs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
