[
https://issues.apache.org/jira/browse/HBASE-8170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609862#comment-13609862
]
Anoop Sam John commented on HBASE-8170:
---------------------------------------
Looks good JM.. Good to see you adding test cases for different conditions and
boundaries. :)
One comment
{code}
+ try {
+ admin.createTable(desc, "a".getBytes(), "z".getBytes(), 2);
+ assertFalse("Should not be able to create a table with only 2 regions
using this API.", true);
+ } catch (IllegalArgumentException eae) {
{code}
Here instead of assertFalse(true) we can use fail(msg)? That will be better for
readability IMO.
> HbaseAdmin.createTable cannot handle creating three regions
> -----------------------------------------------------------
>
> Key: HBASE-8170
> URL: https://issues.apache.org/jira/browse/HBASE-8170
> Project: HBase
> Issue Type: Bug
> Components: Admin
> Affects Versions: 0.94.5
> Reporter: Edward C. Skoviak
> Assignee: Jean-Marc Spaggiari
> Priority: Minor
> Attachments: HBASE-8170-v0-trunk.patch, HBASE-8170-v1-trunk.patch
>
>
> createTable(HTableDescriptor desc, byte [] startKey, byte [] endKey, int
> numRegions) (line #370) dictates that you must specify a minimum of three
> regions, however is not able to handle being fed a value three. This is a
> result of line #379 where it attempts to create the key splits, and calls
> Bytes.Split with a value of 0 for the third parameter. createTable should
> instead just create a byte[][] with the startKey and endKey in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
