[
https://issues.apache.org/jira/browse/HBASE-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613499#comment-13613499
]
stack commented on HBASE-8144:
------------------------------
failedOpenTracker
Oh no!!!! More state keeping in AM!!!!
(Makes sense though; nice comment).
Good comment below:
+ // No need to use putIfAbsent, or extra synchronization since
+ // this whole handleRegion block is locked on the encoded region
+ // name, and failedOpenTracker is updated only in this block
Is it worth WARN logging this rare, but extraordinary state:
+ if (failedOpenCount.incrementAndGet() >= maximumAttempts) {
... logging the region involved?
Or, is the logging done here:
+ LOG.warn("Failed to transition " + hri + " on " + serverName + ": " +
state);
If so, fine.
+1
> Limit number of attempts to assign a region
> -------------------------------------------
>
> Key: HBASE-8144
> URL: https://issues.apache.org/jira/browse/HBASE-8144
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.95.0, 0.98.0
>
> Attachments: trunk-8144.patch, trunk-8144_v2.patch,
> trunk-8144_v3.patch
>
>
> In sending a region open request to a region server, we make sure we try at
> most some configured times. However, once the request is accepted by the
> region server, the region could go through this transition forever:
> failed_open (in ZK) => closed => opening => failed_open (in ZK), assuming no
> RPC/network issue.
> It will be good to break the loop and limit the number of tries and move the
> region to failed_open state (will be introduced in HBASE-8137)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
