[
https://issues.apache.org/jira/browse/HBASE-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614718#comment-13614718
]
Jonathan Hsieh commented on HBASE-8196:
---------------------------------------
Ok, a good chunk of this is ws comments changes. Ideally we'd have less of
this in a review.
Was this intentional? (enable as setting for another "EXPERIMENTAL" feature)
{code}
# Uncomment below if you intend to use the EXPERIMENTAL off heap cache.
-# export HBASE_OPTS="$HBASE_OPTS -XX:MaxDirectMemorySize="
+export HBASE_OPTS="$HBASE_OPTS -XX:MaxDirectMemorySize=2g"
# Set hbase.offheapcache.percentage in hbase-site.xml to a nonzero value.
{code}
Any compatibility concerns? Can you spell out the cases? In an upgrade
situation, during splitting what happens when an old RS hosts META and get
issued a call from the newer RS with the MultiRowMutationEndpoint coproc? A
bunch of code was removed -- would we have a problem if new RS hosting META
being issued a meta mutation from an older splitting RS.
Hopefully this would explain this:
{code}
this.balancer.setMasterServices(this);
- // Fixing up missing daughters if any
+ // Fixing up missing daughters if any.
+ //After HBASE-7721, we do not need this, but we keep it since in 0.94
during
+ //rolling restart this might be needed
status.setStatus("Fixing up missing daughters");
fixupDaughters(status);
{code}
> Port HBASE-7721 Atomic multi-row mutations in META to 0.94
> ----------------------------------------------------------
>
> Key: HBASE-8196
> URL: https://issues.apache.org/jira/browse/HBASE-8196
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.7
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.94.7
>
> Attachments: hbase-7721_v4-0.94.patch
>
>
> There has been some interest in porting region merge (HBASE-7403), and making
> splits more stable in 0.94. For online merge, we depend on HBASE-7721, thus
> we might need the backport.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
