[ 
https://issues.apache.org/jira/browse/HBASE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617675#comment-13617675
 ] 

Ted Yu commented on HBASE-8204:
-------------------------------

{code}
+        //  file is closed, false when it starts the lease recovery, true when 
the lease recovery
{code}
I understand the above comment. But for people unfamiliar with how lease 
recovery works, it may be clearer to separate the two cases w.r.t. whether the 
file is closed.
Simplest is to use semicolon following 'file is closed'.
{code}
-        } else if (e instanceof LeaseExpiredException &&
-            e.getMessage().contains("File does not exist")) {
-          // This exception comes out instead of FNFE, fix it
{code}
The above is not needed anymore ?

Please consider changing the subject of this JIRA because we're taking out 
fs.append() call.
                
> Logging improvements and try to recover lease even when append is not 
> activated.
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-8204
>                 URL: https://issues.apache.org/jira/browse/HBASE-8204
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 0.96.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>            Priority: Minor
>         Attachments: 8204.v2.patch, 8204.v2.patch, 8204.v3.patch, 
> HBASE-8204.v1.patch
>
>
> See patch :-).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to