[
https://issues.apache.org/jira/browse/HBASE-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617989#comment-13617989
]
stack commented on HBASE-8224:
------------------------------
[~enis] We have 11 modules of which at least 5 would need the shadow module you
suggest. That is a bunch of modules. And then there is hadoop3 one day?
I tried again to make the classifiers work (if they worked, it'd be 'elegant'
-- caveat we are talking maven world here). I tried adding the dependencies to
hbase-assembly so we could then do dependencySet in the assembly descriptor. I
could get the hbase-*-hadoop?.jars to show up but they would come w/o their
dependencies. I tried getting arty w/ maven coordinate specifications and
dependencySet but it started to turn erratic on me.
Things I've learned (not sure if they are hard and fast rules -- but I have not
been able to get past them):
+ We cannot read the pom.version off the command-line. It has to be hard-coded
in the top-level pom and in all submodules. I cannot interpolate a property
into the pom.version either (to add hadoop1 or hadoop2 suffix); mvn just
complains.
+ We could add hadoop? to the version but there is no connection between
version and hadoop profile so we could have a hadoop1 added to jar names though
we build the assembly with the hadoop2 profile (Maybe this is not too bad....
Serves you right if you end up w/ this combo).
How we going to change the version though given the above? Making the assembly
package, its not too bad. Could just name the assembly/package for the hadoop
version and leave the jar alone unadorned with hadoop version. Publishing to
maven we'd do something crazy like change the version number, commit, build and
upload for hadoop1, then commit again, build, and upload for hadoop2?
Any other ideas?
> Add '-hadoop1' or '-hadoop2' to our version string
> --------------------------------------------------
>
> Key: HBASE-8224
> URL: https://issues.apache.org/jira/browse/HBASE-8224
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Attachments: 8224-adding.classifiers.txt
>
>
> So we can publish both the hadoop1 and the hadoop2 jars to a maven
> repository, and so we can publish two packages, one for hadoop1 and one for
> hadoop2, given how maven works, our only alternative (to the best of my
> knowledge and after consulting others) is by amending the version string to
> include hadoop1 or hadoop2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
