[ https://issues.apache.org/jira/browse/HBASE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618752#comment-13618752 ]
Hadoop QA commented on HBASE-7579: ---------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12576365/HBASE-7579-v5.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 8 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor org.apache.hadoop.hbase.client.TestAdmin org.apache.hadoop.hbase.master.TestTableLockManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5080//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5080//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5080//console This message is automatically generated. > HTableDescriptor equals method fails if results are returned in a different > order > --------------------------------------------------------------------------------- > > Key: HBASE-7579 > URL: https://issues.apache.org/jira/browse/HBASE-7579 > Project: HBase > Issue Type: Bug > Components: Admin > Affects Versions: 0.95.0, 0.94.6 > Reporter: Aleksandr Shulman > Assignee: Aleksandr Shulman > Priority: Minor > Fix For: 0.95.0, 0.94.7 > > Attachments: HBASE-7579-0.94.patch, HBASE-7579-v1.patch, > HBASE-7579-v2.patch, HBASE-7579-v3.patch, HBASE-7579-v4.patch, > HBASE-7579-v5.patch > > > HTableDescriptor's compareTo function compares a set of HColumnDescriptors > against another set of HColumnDescriptors. It iterates through both, relying > on the fact that they will be in the same order. > In my testing, I may have seen this issue come up, so I decided to fix it. > It's a straightforward fix. I convert the sets into a hashset for O(1) > lookups (at least in theory), then I check that all items in the first set > are found in the second. > Since the sizes are the same, we know that if all elements showed up in the > second set, then they must be equal. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira