[ 
https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619783#comment-13619783
 ] 

Jean-Marc Spaggiari commented on HBASE-8220:
--------------------------------------------

Many tests failed...

I'm not concerned by most of them, but the 2 TestHTablePool tests are more 
concerning me.

I will try to re-run them separatly.


Tests in error:
  
testDeleteAllTimestamps(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler)
  
testDeleteSingleTimestamp(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler)
  testIncrement(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler)
  testCheckAndPut(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler)
  
testCheckAndDelete(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler)
  testScan(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler)
  testMetrics(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler)
  testExists(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler)
  testPutGet(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler)
  
testPutGetMultiple(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler)
  
testDeleteMultiple(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler)
  testDelete(org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler)
  testGetTableDescriptor(org.apache.hadoop.hbase.rest.client.TestRemoteTable): 
schema request returned 500
  testGet(org.apache.hadoop.hbase.rest.client.TestRemoteTable): get request 
returned 400
  testMultiGet(org.apache.hadoop.hbase.rest.client.TestRemoteTable): get 
request returned 500
  testPut(org.apache.hadoop.hbase.rest.client.TestRemoteTable): put request 
failed with 500
  
testTableWithMaxSize(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool)
  
testCloseTablePool(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool)
  
testTableWithStringName(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool)
  
testTableWithByteArrayName(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool)
  
testTablesWithDifferentNames(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool)
  
testDeprecatedUsagePattern(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool)
  
testTableWithMaxSize(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool)
  
testCloseTablePool(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool)
  
testTableWithStringName(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool)
  
testTableWithByteArrayName(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool)
  
testTablesWithDifferentNames(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool)
  
testDeprecatedUsagePattern(org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool)
  testDML(org.apache.hadoop.hbase.avro.TestAvroServer)
  testFamilyAdminAndMetadata(org.apache.hadoop.hbase.avro.TestAvroServer)

Tests run: 1332, Failures: 34, Errors: 30, Skipped: 13

                
> can we record the count opened HTable for HTablePool
> ----------------------------------------------------
>
>                 Key: HBASE-8220
>                 URL: https://issues.apache.org/jira/browse/HBASE-8220
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 0.94.3
>            Reporter: cuijianwei
>         Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, 
> HBASE-8220-0.94.3.txt-v2, HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt
>
>
> In HTablePool, we have a method getCurrentPoolSize(...) to get how many 
> opened HTable has been pooled. However, we don't know ConcurrentOpenedHTable 
> which means the count of HTable get from HTablePool.getTable(...) and don't 
> return to HTablePool by PooledTable.close(). The ConcurrentOpenedHTable may 
> be meaningful because it indicates how many HTables should be opened for the 
> application which may help us set the appropriate MaxSize of HTablePool. 
> Therefore, we can and a ConcurrentOpenedHTable as a counter in HTablePool.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to